Bug fixes

This commit is contained in:
Juan Gilsanz Polo
2024-03-24 02:46:39 +01:00
parent 822c65c4e6
commit aa0a468d19
3 changed files with 53 additions and 40 deletions

View File

@@ -58,7 +58,7 @@ class BookmarkItem extends ConsumerWidget {
child: ClipRRect( child: ClipRRect(
borderRadius: tabletMode ? BorderRadius.circular(28) : BorderRadius.circular(0), borderRadius: tabletMode ? BorderRadius.circular(28) : BorderRadius.circular(0),
child: Builder( child: Builder(
builder: (context) { builder: (ctx) {
return ContextMenuWidget( return ContextMenuWidget(
menuProvider: (request) => Menu( menuProvider: (request) => Menu(
children: [ children: [
@@ -93,7 +93,7 @@ class BookmarkItem extends ConsumerWidget {
), ),
MenuAction( MenuAction(
callback: () { callback: () {
final box = context.findRenderObject() as RenderBox?; final box = ctx.findRenderObject() as RenderBox?;
Future.delayed(_durationTime).then( Future.delayed(_durationTime).then(
(value) => Share.share( (value) => Share.share(
bookmark.url!, bookmark.url!,

View File

@@ -25,7 +25,10 @@ class Onboarding extends ConsumerWidget {
return Center( return Center(
child: ConstrainedBox( child: ConstrainedBox(
constraints: constraints.maxWidth > Sizes.tabletBreakpoint constraints: constraints.maxWidth > Sizes.tabletBreakpoint
? const BoxConstraints(maxWidth: 500, maxHeight: 600) ? BoxConstraints(
maxWidth: 500,
maxHeight: constraints.maxHeight > 800 ? 800 : constraints.maxHeight - 100,
)
: const BoxConstraints.expand(), : const BoxConstraints.expand(),
child: Container( child: Container(
decoration: constraints.maxWidth > Sizes.tabletBreakpoint decoration: constraints.maxWidth > Sizes.tabletBreakpoint

View File

@@ -108,43 +108,53 @@ class WebViewScreen extends HookConsumerWidget {
), ),
], ],
), ),
PopupMenuButton( Builder(
itemBuilder: (context) => [ builder: (ctx) {
PopupMenuItem( return PopupMenuButton(
onTap: () => Share.shareUri(Uri.parse(bookmark.url!)), itemBuilder: (context) => [
child: Row( PopupMenuItem(
children: [ onTap: () {
const Icon(Icons.share_rounded), final box = ctx.findRenderObject() as RenderBox?;
const SizedBox(width: 12), Share.share(
Flexible(child: Text(t.webview.share)), bookmark.url!,
], sharePositionOrigin: box!.localToGlobal(Offset.zero) & box.size,
), );
), },
PopupMenuItem( child: Row(
onTap: () => copyToClipboard( children: [
key: ScaffoldMessengerKeys.root, const Icon(Icons.share_rounded),
value: bookmark.url!, const SizedBox(width: 12),
successMessage: t.webview.linkCopiedClipboard, Flexible(child: Text(t.webview.share)),
), ],
child: Row( ),
children: [ ),
const Icon(Icons.copy_rounded), PopupMenuItem(
const SizedBox(width: 12), onTap: () => copyToClipboard(
Flexible(child: Text(t.webview.copyLinkClipboard)), key: ScaffoldMessengerKeys.root,
], value: bookmark.url!,
), successMessage: t.webview.linkCopiedClipboard,
), ),
PopupMenuItem( child: Row(
onTap: () => openUrl(bookmark.url!), children: [
child: Row( const Icon(Icons.copy_rounded),
children: [ const SizedBox(width: 12),
const Icon(Icons.open_in_browser_rounded), Flexible(child: Text(t.webview.copyLinkClipboard)),
const SizedBox(width: 12), ],
Flexible(child: Text(t.webview.openInSystemBrowser)), ),
], ),
), PopupMenuItem(
), onTap: () => openUrl(bookmark.url!),
], child: Row(
children: [
const Icon(Icons.open_in_browser_rounded),
const SizedBox(width: 12),
Flexible(child: Text(t.webview.openInSystemBrowser)),
],
),
),
],
);
},
), ),
], ],
), ),