From 3584c96312463356db59023c69aa6c5e750864c3 Mon Sep 17 00:00:00 2001 From: Juan Gilsanz Polo Date: Fri, 1 Mar 2024 10:41:27 +0100 Subject: [PATCH] Small improvements --- lib/screens/bookmarks/ui/bookmark_item.dart | 17 +++++++++++------ lib/screens/tags/ui/tags.dart | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/lib/screens/bookmarks/ui/bookmark_item.dart b/lib/screens/bookmarks/ui/bookmark_item.dart index 74d7034..80018e5 100644 --- a/lib/screens/bookmarks/ui/bookmark_item.dart +++ b/lib/screens/bookmarks/ui/bookmark_item.dart @@ -12,6 +12,9 @@ import 'package:linkdy/providers/app_status.provider.dart'; import 'package:linkdy/utils/date_to_string.dart'; import 'package:super_context_menu/super_context_menu.dart'; +// Wait until the context menu close animation animation finishes +Duration _durationTime = const Duration(milliseconds: 150); + class BookmarkItem extends ConsumerWidget { final Bookmark bookmark; final void Function(Bookmark bookmark) onSelect; @@ -58,7 +61,7 @@ class BookmarkItem extends ConsumerWidget { menuProvider: (request) => Menu( children: [ MenuAction( - callback: () => onReadUnread(bookmark), + callback: () => Future.delayed(_durationTime).then((value) => onReadUnread(bookmark)), title: bookmark.unread == true ? t.bookmarks.bookmarkOptions.markAsRead : t.bookmarks.bookmarkOptions.markAsUnread, @@ -67,7 +70,7 @@ class BookmarkItem extends ConsumerWidget { ), ), MenuAction( - callback: () => onArchiveUnarchive(bookmark), + callback: () => Future.delayed(_durationTime).then((value) => onArchiveUnarchive(bookmark)), title: bookmark.isArchived == true ? t.bookmarks.bookmarkOptions.unarchive : t.bookmarks.bookmarkOptions.archive, @@ -80,14 +83,16 @@ class BookmarkItem extends ConsumerWidget { image: MenuImage.icon(Icons.share_rounded), children: [ MenuAction( - callback: () => onShareInternally(bookmark), + callback: () => Future.delayed(_durationTime).then((value) => onShareInternally(bookmark)), title: bookmark.shared == true ? t.bookmarks.bookmarkOptions.unshareInternally : t.bookmarks.bookmarkOptions.shareInternally, image: MenuImage.icon(Icons.input_rounded), ), MenuAction( - callback: () => Share.shareUri(Uri.parse(bookmark.url!)), + callback: () => Future.delayed(_durationTime).then( + (value) => Share.shareUri(Uri.parse(bookmark.url!)), + ), title: t.bookmarks.bookmarkOptions.shareThirdPartyApp, image: MenuImage.icon(Icons.output_rounded), ), @@ -95,12 +100,12 @@ class BookmarkItem extends ConsumerWidget { ), MenuSeparator(), MenuAction( - callback: () => onEdit(bookmark), + callback: () => Future.delayed(_durationTime).then((value) => onEdit(bookmark)), title: t.bookmarks.bookmarkOptions.edit, image: MenuImage.icon(Icons.edit_rounded), ), MenuAction( - callback: () => onDelete(bookmark), + callback: () => Future.delayed(_durationTime).then((value) => onDelete(bookmark)), title: t.bookmarks.bookmarkOptions.delete, image: MenuImage.icon(Icons.delete_rounded), attributes: const MenuActionAttributes(destructive: true), diff --git a/lib/screens/tags/ui/tags.dart b/lib/screens/tags/ui/tags.dart index e90da28..06314e9 100644 --- a/lib/screens/tags/ui/tags.dart +++ b/lib/screens/tags/ui/tags.dart @@ -46,7 +46,7 @@ class TagsScreen extends ConsumerWidget { ], body: SafeArea( top: false, - bottom: false, + bottom: true, child: Builder( builder: (context) => RefreshIndicator( displacement: 120,